feat: delayed hydration #26468
Open
feat: delayed hydration #26468
+236
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🎉 |
packages/nuxt/src/components/runtime/client-delayed-component.ts
Outdated
Show resolved
Hide resolved
| idleHandle = null | ||
| } | ||
| }) | ||
| return () => h('div', {}, [ |
There was a problem hiding this comment.
We do not, I was thinking about it here, I'll remove it
Now that I think about it, do we need the div in the visibility based component in the import.meta.server check?
|
I was thinking of changing up the way visibility based component behaves, to ensure we don't pollute the DOM unnecessarily with extra nodes. What do you think? Do note I wrote this on my phone right in this message so it may have some mistakes, but I'm talking about the general idea. return () => {
if (!isIntersecting.value && (!instance.vnode.el || !nuxt.isHydrating)) {
return h('div', { ref: el });
}
if (isIntersecting.value) {
return h(componentLoader, attrs);
} else {
const fragmentHTML = getFragmentHTML(instance.vnode.el ?? null, true)?.join('') || '';
return createVNode(createStaticVNode(fragmentHTML, 1));
}
}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#24242
❓ Type of change
📚 Description
Lazy loading is a very beneficial addition to the nuxt core. Natively supporting delayed hydration will provide significant performance improvement. Moreover, it will reduce the amount of boilerplate code needed for manual implementations, and will reduce bundle size by not requiring external modules for something that may very well be handled out-of-the-box, as part of the
Lazycomponents behavior.📝 Checklist
TODO (optional):